Skip to content

feat: migrate math/base/ops/add to number/float64/base/add #4999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

feat: migrate math/base/ops/add to number/float64/base/add #4999

wants to merge 2 commits into from

Conversation

@gururaj1512
Copy link
Member

Progresses #2261.

Description

What is the purpose of this pull request?

This pull request:

  • feat: migrate math/base/ops/add to number/float64/base/add

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@gururaj1512
feat: migrate math/base/ops/add to number/float64/base/add
3a37774 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@gururaj1512
chore: update dependencies
6852230 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
array/base/binary2d $\color{green}135/135$
$\color{green}+100.00\%$ 		$\color{green}8/8$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}135/135$
$\color{green}+100.00\%$
array/base/binary3d $\color{green}146/146$
$\color{green}+100.00\%$ 		$\color{green}10/10$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}146/146$
$\color{green}+100.00\%$
array/base/binary4d $\color{green}157/157$
$\color{green}+100.00\%$ 		$\color{green}11/11$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}157/157$
$\color{green}+100.00\%$
array/base/binary5d $\color{green}168/168$
$\color{green}+100.00\%$ 		$\color{green}12/12$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}168/168$
$\color{green}+100.00\%$
array/base/binarynd $\color{green}148/148$
$\color{green}+100.00\%$ 		$\color{green}8/8$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}148/148$
$\color{green}+100.00\%$
array/base/broadcasted-binary2d $\color{green}175/175$
$\color{green}+100.00\%$ 		$\color{green}8/8$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}175/175$
$\color{green}+100.00\%$
array/base/broadcasted-binary3d $\color{green}196/196$
$\color{green}+100.00\%$ 		$\color{green}8/8$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}196/196$
$\color{green}+100.00\%$
array/base/broadcasted-binary4d $\color{green}217/217$
$\color{green}+100.00\%$ 		$\color{green}12/12$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}217/217$
$\color{green}+100.00\%$
array/base/broadcasted-binary5d $\color{green}238/238$
$\color{green}+100.00\%$ 		$\color{green}14/14$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}238/238$
$\color{green}+100.00\%$
array/base $\color{green}1842/1842$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}0/0$
$\color{green}+100.00\%$ 		$\color{green}1842/1842$
$\color{green}+100.00\%$
array/base/mskbinary2d $\color{green}145/145$
$\color{green}+100.00\%$ 		$\color{green}7/7$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}145/145$
$\color{green}+100.00\%$
array/base/mskbinary3d $\color{green}164/164$
$\color{green}+100.00\%$ 		$\color{green}11/11$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}164/164$
$\color{green}+100.00\%$
array/base/mskbinary4d $\color{green}171/171$
$\color{green}+100.00\%$ 		$\color{green}11/11$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}171/171$
$\color{green}+100.00\%$
array/base/mskbinary5d $\color{green}186/186$
$\color{green}+100.00\%$ 		$\color{green}12/12$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}186/186$
$\color{green}+100.00\%$
error/tools/id2pkg $\color{green}95/95$
$\color{green}+100.00\%$ 		$\color{green}7/7$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}95/95$
$\color{green}+100.00\%$
error/tools/pkg2id $\color{green}95/95$
$\color{green}+100.00\%$ 		$\color{green}7/7$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}95/95$
$\color{green}+100.00\%$
math/base/ops $\color{green}249/249$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}0/0$
$\color{green}+100.00\%$ 		$\color{green}249/249$
$\color{green}+100.00\%$
math/base/ops/add3 $\color{green}174/174$
$\color{green}+100.00\%$ 		$\color{green}5/5$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}174/174$
$\color{green}+100.00\%$
math/base/ops/add4 $\color{green}176/176$
$\color{green}+100.00\%$ 		$\color{green}5/5$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}176/176$
$\color{green}+100.00\%$
math/base/ops/add5 $\color{green}178/178$
$\color{green}+100.00\%$ 		$\color{green}5/5$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}178/178$
$\color{green}+100.00\%$
math/base/ops/addf $\color{green}177/177$
$\color{green}+100.00\%$ 		$\color{green}5/5$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}177/177$
$\color{green}+100.00\%$
math/base/ops/div $\color{green}172/172$
$\color{green}+100.00\%$ 		$\color{green}5/5$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}172/172$
$\color{green}+100.00\%$
math/base/ops $\color{green}249/249$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}0/0$
$\color{green}+100.00\%$ 		$\color{green}249/249$
$\color{green}+100.00\%$
math/base/ops/mul $\color{green}172/172$
$\color{green}+100.00\%$ 		$\color{green}5/5$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}172/172$
$\color{green}+100.00\%$
math/base/ops/sub $\color{green}172/172$
$\color{green}+100.00\%$ 		$\color{green}5/5$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}172/172$
$\color{green}+100.00\%$
math/strided/ops/add-by $\color{green}206/206$
$\color{green}+100.00\%$ 		$\color{green}5/5$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}206/206$
$\color{green}+100.00\%$
math/strided/ops/add $\color{green}582/582$
$\color{green}+100.00\%$ 		$\color{green}13/13$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}582/582$
$\color{green}+100.00\%$
namespace/alias2pkg $\color{green}95/95$
$\color{green}+100.00\%$ 		$\color{green}7/7$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}95/95$
$\color{green}+100.00\%$
namespace $\color{green}95/95$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}95/95$
$\color{green}+100.00\%$
namespace/pkg2alias $\color{green}100/100$
$\color{green}+100.00\%$ 		$\color{green}10/10$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}100/100$
$\color{green}+100.00\%$
namespace/pkg2related $\color{green}100/100$
$\color{green}+100.00\%$ 		$\color{green}10/10$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}100/100$
$\color{green}+100.00\%$
namespace/pkg2standalone $\color{green}95/95$
$\color{green}+100.00\%$ 		$\color{green}7/7$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}95/95$
$\color{green}+100.00\%$
namespace/standalone2pkg $\color{green}95/95$
$\color{green}+100.00\%$ 		$\color{green}7/7$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}95/95$
$\color{green}+100.00\%$
ndarray/base/unary-accumulate $\color{red}4001/8714$
$\color{green}+45.91\%$ 		$\color{green}44/44$
$\color{green}+100.00\%$ 		$\color{red}0/43$
$\color{green}+0.00\%$ 		$\color{red}4001/8714$
$\color{green}+45.91\%$
number/float64/base $\color{green}204/204$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}0/0$
$\color{green}+100.00\%$ 		$\color{green}204/204$
$\color{green}+100.00\%$
number/float64/base/add $\color{green}172/172$
$\color{green}+100.00\%$ 		$\color{green}5/5$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}172/172$
$\color{green}+100.00\%$
number/float64/base $\color{green}204/204$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}0/0$
$\color{green}+100.00\%$ 		$\color{green}204/204$
$\color{green}+100.00\%$
strided/base/binary-signature-callbacks $\color{red}259/283$
$\color{green}+91.52\%$ 		$\color{red}31/39$
$\color{green}+79.49\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{red}259/283$
$\color{green}+91.52\%$
strided/base/binary $\color{green}604/604$
$\color{green}+100.00\%$ 		$\color{green}38/38$
$\color{green}+100.00\%$ 		$\color{green}6/6$
$\color{green}+100.00\%$ 		$\color{green}604/604$
$\color{green}+100.00\%$
strided/base/dmap2 $\color{green}206/206$
$\color{green}+100.00\%$ 		$\color{green}9/9$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}206/206$
$\color{green}+100.00\%$
strided/base/dmskmap2 $\color{green}224/224$
$\color{green}+100.00\%$ 		$\color{green}10/10$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}224/224$
$\color{green}+100.00\%$
strided/base $\color{green}460/460$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}0/0$
$\color{green}+100.00\%$ 		$\color{green}460/460$
$\color{green}+100.00\%$
strided/base/map-by2 $\color{green}608/608$
$\color{green}+100.00\%$ 		$\color{green}42/42$
$\color{green}+100.00\%$ 		$\color{green}6/6$
$\color{green}+100.00\%$ 		$\color{green}608/608$
$\color{green}+100.00\%$
utils/decorate-after $\color{red}718/722$
$\color{green}+99.45\%$ 		$\color{red}51/52$
$\color{green}+98.08\%$ 		$\color{green}14/14$
$\color{green}+100.00\%$ 		$\color{red}718/722$
$\color{green}+99.45\%$
utils $\color{green}2017/2017$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}0/0$
$\color{green}+100.00\%$ 		$\color{green}2017/2017$
$\color{green}+100.00\%$
utils/filter-arguments $\color{green}147/147$
$\color{green}+100.00\%$ 		$\color{green}10/10$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}147/147$
$\color{green}+100.00\%$
utils/map-arguments $\color{green}141/141$
$\color{green}+100.00\%$ 		$\color{green}9/9$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}141/141$
$\color{green}+100.00\%$
utils/map-reduce-right $\color{green}413/413$
$\color{green}+100.00\%$ 		$\color{green}20/20$
$\color{green}+100.00\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{green}413/413$
$\color{green}+100.00\%$
utils/map-reduce $\color{green}413/413$
$\color{green}+100.00\%$ 		$\color{green}20/20$
$\color{green}+100.00\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{green}413/413$
$\color{green}+100.00\%$
utils/map2-right $\color{green}737/737$
$\color{green}+100.00\%$ 		$\color{green}50/50$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}737/737$
$\color{green}+100.00\%$
utils/map2 $\color{green}737/737$
$\color{green}+100.00\%$ 		$\color{green}50/50$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}737/737$
$\color{green}+100.00\%$
utils/mask-arguments $\color{green}207/207$
$\color{green}+100.00\%$ 		$\color{green}20/20$
$\color{green}+100.00\%$ 		$\color{green}8/8$
$\color{green}+100.00\%$ 		$\color{green}207/207$
$\color{green}+100.00\%$
utils/pick-arguments $\color{green}207/207$
$\color{green}+100.00\%$ 		$\color{green}21/21$
$\color{green}+100.00\%$ 		$\color{green}8/8$
$\color{green}+100.00\%$ 		$\color{green}207/207$
$\color{green}+100.00\%$
utils/reduce-right $\color{green}385/385$
$\color{green}+100.00\%$ 		$\color{green}18/18$
$\color{green}+100.00\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{green}385/385$
$\color{green}+100.00\%$
utils/reduce $\color{green}385/385$
$\color{green}+100.00\%$ 		$\color{green}18/18$
$\color{green}+100.00\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{green}385/385$
$\color{green}+100.00\%$
utils/reduce2d $\color{green}153/153$
$\color{green}+100.00\%$ 		$\color{green}17/17$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}153/153$
$\color{green}+100.00\%$
utils/reject-arguments $\color{green}147/147$
$\color{green}+100.00\%$ 		$\color{green}10/10$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}147/147$
$\color{green}+100.00\%$
utils/thunk $\color{green}115/115$
$\color{green}+100.00\%$ 		$\color{green}8/8$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}115/115$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@gururaj1512
Copy link
Member Author

@kgryte, I plan to migrate the math/base/ops/* packages to number/*, as mentioned in #2261, one by one. This approach will make the review and maintenance process easier. If the initial migrations are reviewed earlier, I can proceed with migrating the remaining packages.

@kgryte
Copy link
Member

kgryte commented Feb 4, 2025

@gururaj1512 Unfortunately, I'll need to close this PR, as it doesn't perform the exact commit sequence we need. Your first commit both removed and added a package, which isn't what we want, as it complicates automatic versioning (i.e., cannot both deprecate and add a new feature in the same commit). Furthermore, you touched the error database, which we don't want, as the error database is append-only. Lastly, we cannot add subsequent commits to this PR, as we need to be able to merge exactly three commits which follow our desired sequence.

@kgryte kgryte closed this Feb 4, 2025
@kgryte kgryte added the Invalid Invalid question, issue, or pull request. label Feb 4, 2025
@gururaj1512
Copy link
Member Author

@gururaj1512 Unfortunately, I'll need to close this PR, as it doesn't perform the exact commit sequence we need. Your first commit both removed and added a package, which isn't what we want, as it complicates automatic versioning (i.e., cannot both deprecate and add a new feature in the same commit). Furthermore, you touched the error database, which we don't want, as the error database is append-only. Lastly, we cannot add subsequent commits to this PR, as we need to be able to merge exactly three commits which follow our desired sequence.

Can you clarify the exact sequence of commits that should be pushed and the specific work that should be done in each commit?

@gururaj1512 gururaj1512 deleted the migrate-math-base-ops-add branch February 4, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Invalid Invalid question, issue, or pull request.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gururaj1512 @stdlib-bot @kgryte